Skip to content

docs: clarify VS Code ignore rules in Python.gitignore#4785

Closed
ViratiAkiraNandhanReddy wants to merge 4 commits intogithub:mainfrom
ViratiAkiraNandhanReddy:patch-1
Closed

docs: clarify VS Code ignore rules in Python.gitignore#4785
ViratiAkiraNandhanReddy wants to merge 4 commits intogithub:mainfrom
ViratiAkiraNandhanReddy:patch-1

Conversation

@ViratiAkiraNandhanReddy
Copy link
Copy Markdown

@ViratiAkiraNandhanReddy ViratiAkiraNandhanReddy commented Jan 18, 2026

This change clarifies how Visual Studio Code workspace files can be optionally ignored in python.gitignore while allowing contributors to track shared settings.json if desired.

Reasons for making this change

  • Many contributors use VS Code and often want to:
  • Avoid committing editor- and user-specific workspace files
  • Still share common editor settings (formatting, linting, tooling) across the project

The current comments reference ignoring the entire .vscode directory but do not clearly document the common pattern of allowing settings.json while ignoring other files. This change improves clarity without altering default behavior.

Merge and Approval Steps

  • Confirm that you've read the contribution guidelines and ensured your PR aligns
  • Ensure CI is passing
  • Get a review and Approval from one of the maintainers

@thorrsson @dooleydevin

This change clarifies how Visual Studio Code workspace files can be optionally ignored in python.gitignore while allowing contributors to track shared settings.json if desired.
@ViratiAkiraNandhanReddy ViratiAkiraNandhanReddy requested a review from a team as a code owner January 18, 2026 04:37
@ViratiAkiraNandhanReddy
Copy link
Copy Markdown
Author

ViratiAkiraNandhanReddy commented Feb 14, 2026

Please Review This PR ; @thorrsson

@ViratiAkiraNandhanReddy
Copy link
Copy Markdown
Author

@dooleydevin

@dooleydevin
Copy link
Copy Markdown
Collaborator

I don't think that making this more verbose is useful, nor do I think committing only the settings.json file is always enough. If you look at the global template, there are a few other VSCode files that also belong in source control.

We include the comment here since it is a common request to ignore the whole folder, but it really goes against our contribution guidelines to do so. We'd end up including snippets like this in every language template if we weren't strict about it.

Going to close this out 👍 I'd recommend adding the contents of the VSCode template to your global ignore file instead if you are running into issues with this.

@dooleydevin dooleydevin closed this Apr 6, 2026
@ViratiAkiraNandhanReddy
Copy link
Copy Markdown
Author

Thanks for taking the time to explain this and for the clarification

I appreciate the suggestion about using the global ignore setup.

I’ll try to come back later with a better-quality, more meaningful PR that fits the project standards better. Thanks again for the feedback.

@dooleydevin

@ViratiAkiraNandhanReddy ViratiAkiraNandhanReddy deleted the patch-1 branch April 6, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants